Skip to content

fix: a Bot's quiet patrol wake says nothing - #39413

Open
CrysisDeu wants to merge 1 commit into
mainfrom
fix/bot-quiet-patrol-wake-only
Open

CrysisDeu wants to merge 1 commit into
mainfrom
fix/bot-quiet-patrol-wake-only

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Bot's thread stays quiet on a patrol wake with no news, and still reports a finished task in full.

A Bot's thread fills with status lines from its work-ledger patrol: "No completed main run since 05:06Z; the post-fix run is pending.", "Fast Gate green on the fixed heads ... Nothing to act on." Since #37881 the prompt asks for them: the one-line patrol reply is a rule a Bot shares with conductor mode, and it forbids nothing_to_do on a patrol wake.

Why it matters

A person reads a Bot's thread once or twice a day. Every quiet wake that writes a line buries the few messages that need them. Conductor mode is different: a person watches it live, so it keeps its one line.

Not a goal

  • Changing conductor mode's patrol reply (it keeps its one line).
  • A dedicated "say" tool that is the only way text reaches a Bot's thread.
  • Changing when a wake fires (the gate, monitor and patrol code are untouched).

What changed (motivation → approach → change)

How a conductor talks on a patrol wake depends on who reads it, so that rule is no longer shared.

Surface Patrol wake, no news Task finished
Conductor mode (and the team lead) one line, as on main full report
Bot no text, nothing_to_do full report, before autonudge_stop
  • agent_parts/spec_prompts.py: the one-line rule moves out of _LEDGER_CONDUCTOR_RULES into _CONDUCTOR_PATROL_REPLY, a conductor-mode section the team lead's _SHARED_CONDUCTOR_RULES_BLOCK also carries (re-exported from src/kiro_crew/agent.py). The shared wake_check now says "reply as your patrol-reply rule says", so each side reads its own rule.
  • crewmate_prompts.json: the Bot's conductor.patrol carries its own rule ("speak only for news"), and how-you-work items 2 and 5 drop the one-line exception.
  • goal-conductor skill step 6 points at "your prompt's patrol-reply rule" without saying which reply it is.
  • docs/system-specs/modules/crew-mode.md describes the split.

Backwards compatibility

Compatible: prompt text only; no config key, tool or stored data changes.

Removes nothing: conductor mode and the team lead keep the same one-line rule text, and the Bot only loses an instruction to post a status line.

Tests

  • test_mate_conductor_parity.py: the old "one line on both conductors" test becomes test_a_patrol_wake_gets_one_line_in_conductor_mode_and_none_on_a_bot (conductor mode and the team lead carry the one-line rule, the Bot carries only its quiet rule, a finished task is reported in full). prompt:patrol_reply is an ALLOWLIST difference with its reason.
  • test_context_composition_contract.py: the two member_how_you_work pins move to the new text.

Proof: PROVEN test/test_context_composition_contract.py::test_stable_text_is_byte_identical[member_how_you_work], test/test_context_composition_contract.py::test_stable_text_is_byte_identical[member_how_you_work_unavailable], test/test_mate_conductor_parity.py::test_every_allowlist_entry_is_still_a_difference (head fdd6a27)

Manual verification

Ran on an isolated pod (signed in, real model): the Bot got a worker task that sleeps 8 minutes, its patrol interval set to 30 s so a quiet wake fires before the task ends. Results are under Real-machine verification.

Real-machine verification

Machine: Dev desktop, Amazon Linux 2023, aarch64, pod limits 4G / 200%
Before: not re-run on a pod. The symptom is the reporter's own Bot thread on 0.13.0rc3 ("No completed main run since 05:06Z; the post-fix run is pending."), and main's prompt (since #37881) asks for that line on every quiet wake.
After (head fdd6a27fa5): `kirocrew pod up bot-quiet-patrol`, Bot task "sleep 480 then touch a file" -> quiet patrol wakes end with `nothing_to_do` and no text; on done the Bot writes "The fourth job is done. `/tmp/qp4/bot.done` was made at 05:45 UTC ... none are left." in that turn.
Cleanup: pod torn down with `kirocrew pod down bot-quiet-patrol`

Screenshots / video

N/A -- prompt text only; no frontend file changes.

Related Issues

Closes #39277

Sibling sweep

Swept: git grep -n "one line a patrol wake|patrol wake gets|one exception" origin/main -- src docs/system-specs
Sibling: src/kiro_crew/builtin_skills/goal-conductor/SKILL.md -- changed here
Sibling: docs/system-specs/modules/crew-mode.md -- changed here

Pattern harvest

Rule candidate: review-prompt
Pattern: a rule about how a conductor talks to the person added to the shared rule set, which a Bot and conductor mode both carry, though their readers differ

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 19, 2026 05:47
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ab622a6371c571f3b8059be43a3968119fc1db75 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ab622a6371c571f3b8059be43a3968119fc1db75 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Each item traces to #39277 or to the conductor-mode wording it keeps. The reversed #37881 pin is named in the description, and the linked issue is evidence it was wrong for the Bot.

What this change ships

Inventory (6 items) — 6 justified

Intent: stop a Bot's thread filling with status lines on quiet patrol wakes, while finished tasks are still reported in full. FIX.

  1. A Bot's quiet patrol wake now writes no text and ends nothing_to_do — justified
  2. A Bot reports a finished task in full before it closes the item or calls autonudge_stop — justified
  3. Conductor mode and the team lead keep the one-line patrol reply, with the same text as on main — justified
  4. The Bot's how-you-work items 2 and 5 lose the one-line patrol exception — justified
  5. The shared wake check and goal-conductor step 6 now say "your patrol-reply rule" instead of "one line" — justified
  6. The parity test lists prompt:patrol_reply as an allowed difference, and the spec describes the split — justified

[FIRST-PRINCIPLES-REVIEWED] ab622a6

Description read

[DESCRIPTION-READ] ae4ea4051e2c54c4ba359b118efd25f663b3a7f6b20134402a36ee2d0f4a4cf6

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ⚠️ review incomplete

GPT 6.1 did not produce a complete verdict for fdd6a27fa544eb8194a78d6af71f6d975fd6a154; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 6.1 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt fdd6a27fa544eb8194a78d6af71f6d975fd6a154 false-positive: <reason, 20 to 500 characters>

A Bot's work-ledger patrol wake with no news for the person now ends
with nothing_to_do instead of a status line, and a finished task is
still reported in full before the patrol stops. Conductor mode keeps
its one-line reply: the patrol-reply rule moves out of the shared rule
set into a conductor-mode section (also carried by the team lead), and
the Bot's conductor.patrol carries its own rule.

Closes #39277
@CrysisDeu
CrysisDeu force-pushed the fix/bot-quiet-patrol-wake-only branch from fdd6a27 to ab622a6 Compare November 19, 2026 05:59
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/learn-cron-dashboard.md, docs/system-specs/modules/security.md, src/kiro_crew/cron.py since this head went green (7f8f9d8 -> 5a0389a); CI re-running. The previous head's runs had all been cancelled about a minute after they started, so this push also restarts them.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ab622a6371c571f3b8059be43a3968119fc1db75 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: the patrol-reply rule moves out of the shared set so each conductor gets the rule its readers need, and the parity allowlist records why the two differ.

Notes

[DESIGN-REVIEWED] ab622a6

Description read

[DESCRIPTION-READ] 9b896700da40013248134e74739f8dee746323ffca4a14077b3dc230e0b65916

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR and #39308 both fix #39277 and change the same 7 files the same way. Each moves the one-line patrol reply out of the shared ledger conductor rules in spec_prompts.py, gives the Bot conductor.patrol its own quiet rule in crewmate_prompts.json, and drops the one-line exception from how-you-work items 2 and 5.

Please keep one of #39308 and #39413 and close the other, carrying over anything only this one has.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A Bot's thread gets a status line on every quiet patrol wake because it shares conductor mode's speaking rules

2 participants